I2C dev interface

Discuss usability issues, general maintenance, and general support issues for a grsecurity-enabled system.

Re: I2C dev interface

Postby PaX Team » Thu Jul 31, 2014 5:56 pm

make fs/compat_ioctl.s should build it.
PaX Team
 
Posts: 2310
Joined: Mon Mar 18, 2002 4:35 pm

Re: I2C dev interface

Postby gregkmoff » Thu Jul 31, 2014 7:29 pm

gregkmoff
 
Posts: 13
Joined: Mon Jul 14, 2014 2:35 pm

Re: I2C dev interface

Postby PaX Team » Thu Jul 31, 2014 8:15 pm

interesting, the structure offsets look fine based on the asm. can you also post a version with the previously mentioned hunk applied?
PaX Team
 
Posts: 2310
Joined: Mon Mar 18, 2002 4:35 pm

Re: I2C dev interface

Postby gregkmoff » Thu Jul 31, 2014 8:26 pm

gregkmoff
 
Posts: 13
Joined: Mon Jul 14, 2014 2:35 pm

Re: I2C dev interface

Postby PaX Team » Thu Jul 31, 2014 8:37 pm

ok, that's bad news as the asm didn't change, it's still a 64 bit load instead of a 32 bit one on line 706. can you remove the PaX part altogether from this file and see if it helps (also upload the corresponding .s please)?
PaX Team
 
Posts: 2310
Joined: Mon Mar 18, 2002 4:35 pm

Re: I2C dev interface

Postby gregkmoff » Thu Jul 31, 2014 8:59 pm

Removing the changes from the file worked.

Here's the .s with the changes:

https://dl.dropboxusercontent.com/u/109924208/compat_ioctl.s.nopax
gregkmoff
 
Posts: 13
Joined: Mon Jul 14, 2014 2:35 pm

Re: I2C dev interface

Postby PaX Team » Fri Aug 01, 2014 7:33 am

i just checked my fix here and it produces the correct assembly (lw instead of ld for loading that pointer from userland) so i don't know why it failed for you. in any case you'll get the working code next time you update to the latest grsec patch.
PaX Team
 
Posts: 2310
Joined: Mon Mar 18, 2002 4:35 pm

Re: I2C dev interface

Postby gregkmoff » Fri Aug 01, 2014 1:16 pm

Did a full clean build and this addressed the problem. Thanks.
gregkmoff
 
Posts: 13
Joined: Mon Jul 14, 2014 2:35 pm

Previous

Return to grsecurity support