Question on grsecurity-2.9.1-3.2.42-201304082214.patch

Discuss usability issues, general maintenance, and general support issues for a grsecurity-enabled system.

Question on grsecurity-2.9.1-3.2.42-201304082214.patch

Postby mlarm » Tue Apr 09, 2013 3:22 pm

Hi

The code below is from the grsecurity-2.9.1-3.2.42-201304082214.patch.

1. There seems to be a typo HOSTCLFAGS instead of HOSTCFLAGS.

2. The the flags in HOSTCFLAGS are, as far as I know, only used when compiling tools used when compiling the kernel. I.e. they are not used for compiling the actual kernel. The KBUILD_CFLAGS variable is used for compiling the actual kernel. Is that the intention with the patch?

Code: Select all
diff --git a/Makefile b/Makefile
index d44f009..158a4a4 100644
--- a/Makefile
+++ b/Makefile
@@ -245,8 +245,9 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
 
 HOSTCC       = gcc
 HOSTCXX      = g++
-HOSTCFLAGS   = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
-HOSTCXXFLAGS = -O2
+HOSTCFLAGS   = -Wall -W -Wmissing-prototypes -Wstrict-prototypes -Wno-unused-parameter -Wno-missing-field-initializers -O2 -fomit-frame-pointer -fno-delete-null-pointer-checks
+HOSTCLFAGS  += $(call cc-option, -Wno-empty-body)
+HOSTCXXFLAGS = -O2 -Wall -W -fno-delete-null-pointer-checks


/M
mlarm
 
Posts: 2
Joined: Tue Apr 02, 2013 11:19 am

Re: Question on grsecurity-2.9.1-3.2.42-201304082214.patch

Postby PaX Team » Tue Apr 09, 2013 4:13 pm

thanks for the catch, the answer is yes on both accounts, i'll fix this in the next patch ;).
PaX Team
 
Posts: 2310
Joined: Mon Mar 18, 2002 4:35 pm


Return to grsecurity support

cron